Repository navigation
Mark every route as a requirement of a declared class or an extension - #85
Merged
Merged
Conversation
routeTable holds every operation the service serves: its method and path,
its handler, and the conformance class it is a requirement of, or extension
for a MobilityAPI extension. newMux routes by it, and the API definition marks
each operation by it, with x-conformance-class naming the class or
x-mobilityapi-extension. The class URIs the conformance declaration lists are
constants the table, the declaration and the tests read.
ats_routes_test.go holds the three to each other: a route marked with a class
the conformance declaration does not list, a route the API definition does
not describe, an operation it describes that no route serves, and a route an
abstract test of Annex A issues that is marked as an extension or with
another class, each fail. Of the 45 routes, 33 are requirements of a declared
class (Common core 3, mf-collection 5, movingfeatures 14, cquery 5, Coverages
core 2, EDR core 4) and 12 are extensions: /health, trajectories, timeseries,
export, bulk, PUT of a moving feature, the live ingest of a temporal property
and the five routes of the geometry continuous query.
Witness. GET /health, /collections/{cid}/trajectories and
/collections/{cid}/timeseries were served and absent from the API
definition, since the routing table and the API definition were two lists.
Measured. go test passes; renaming /health in the API definition fails the
test from both sides, the served route undescribed and the described one
unserved. samples/api-definition.json is what the service writes, emitted as
samples.go writes it; the same emission over master reproduces master's
sample byte for byte.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
routeTable holds every operation the service serves: its method and path,
its handler, and the conformance class it is a requirement of, or extension
for a MobilityAPI extension. newMux routes by it, and the API definition marks
each operation by it, with x-conformance-class naming the class or
x-mobilityapi-extension. The class URIs the conformance declaration lists are
constants the table, the declaration and the tests read.
ats_routes_test.go holds the three to each other: a route marked with a class
the conformance declaration does not list, a route the API definition does
not describe, an operation it describes that no route serves, and a route an
abstract test of Annex A issues that is marked as an extension or with
another class, each fail. Of the 45 routes, 33 are requirements of a declared
class (Common core 3, mf-collection 5, movingfeatures 14, cquery 5, Coverages
core 2, EDR core 4) and 12 are extensions: /health, trajectories, timeseries,
export, bulk, PUT of a moving feature, the live ingest of a temporal property
and the five routes of the geometry continuous query.
Witness. GET /health, /collections/{cid}/trajectories and
/collections/{cid}/timeseries were served and absent from the API
definition, since the routing table and the API definition were two lists.
Measured. go test passes; renaming /health in the API definition fails the
test from both sides, the served route undescribed and the described one
unserved. samples/api-definition.json is what the service writes, emitted as
samples.go writes it; the same emission over master reproduces master's
sample byte for byte.